Retire rose site #104
Merged
Retire rose site #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this ready to review, but that the tests are failing on master due to inability to install Pygraphviz |
wxtim
force-pushed
the
retire_ROSE_SITE
branch
from
68954b8
to
a6a61e1
Compare
* master: fix breakage caused by rose popener always returning decoded str Pin to Python 3.9.
MetRonnie
approved these changes
Jan 7, 2022
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
|
Tests are failing, possibly a DNS glitch on the actions side, however, also likely an error in the way we are setting / testing the ROSE_ORIG_HOST. So long as both sides use the FQDN we should be good, however, we are clearly getting different results. E - ROSE_ORIG_HOST=fv-az397-136.digkgshymtuujfwfpq2czj2vug.jx.internal.cloudapp.net |
oliver-sanders
approved these changes
Jan 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13