Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workflow ID instead of workflow name in queries #433

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

kinow
Copy link
Member

@kinow kinow commented Mar 27, 2020

These changes close #422

We have the user (same from the URL) that is pre-fetched in the Route's. So this PR is simply using that user.username to use as parameter in the query, instead of using the workflow name.

This is necessary for #420 , as there the deltas use the workflow ID, not the name.

Further work to support URL's with other user's username is part of another issue 馃憤

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow kinow added this to the 0.2 milestone Mar 27, 2020
@kinow kinow self-assigned this Mar 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #433 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   44.62%   44.62%           
=======================================
  Files          37       37           
  Lines         856      856           
  Branches       67       67           
=======================================
  Hits          382      382           
  Misses        461      461           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c01d745...99c46ab. Read the comment docs.

@kinow
Copy link
Member Author

kinow commented Mar 27, 2020

An easy way to review, is going through graph/$workflow, tree/$workflow, and workflow/$workflow, and looking at the debug log in the browser console. The query must use the workflow ID.

image

@hjoliver hjoliver merged commit d26d0e9 into cylc:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use workflow ID instead of workflow name in GraphQL queries
4 participants