added flake8-type-checking #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
(MyPy is failing for reasons probably unrelated to this PR) |
oliver-sanders
approved these changes
Oct 17, 2023
MetRonnie
approved these changes
Oct 17, 2023
|
FYI: MyPy update has broken the test on master test@master: https://github.com/cylc/cylc-uiserver/actions/runs/6547017705 |
MetRonnie
reviewed
Oct 17, 2023
cylc/uiserver/handlers.py
Outdated
| @@ -97,7 +98,7 @@ def is_token_authenticated(handler: 'CylcAppHandler') -> bool: | |||
| In these cases the bearer of the token is awarded full privileges. | |||
| """ | |||
| identity_provider: JPSIdentityProvider = ( | |||
| handler.serverapp.identity_provider | |||
| handler.serverapp.identity_provider # type: ignore | |||
There was a problem hiding this comment.
It is better to be specific about which error we are ignoring, so that other valid errors can still be flagged. The error code is displayed in square brackets at the end of the message:
Item "None" of "Optional[ServerApp]" has no attribute "identity_provider" [union-attr]
Suggested change
| handler.serverapp.identity_provider # type: ignore | |
| handler.serverapp.identity_provider # type: ignore[union-attr] |
|
|
||
| # Suppress the following messages: | ||
| # By default the bodies of untyped functions are not checked, consider using --check-untyped-defs | ||
| disable_error_code = annotation-unchecked |
There was a problem hiding this comment.
(This is not strictly needed as those messages are informational and don't fail the check)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 75.42% 75.38% -0.04%
==========================================
Files 12 12
Lines 1428 1426 -2
Branches 236 236
==========================================
- Hits 1077 1075 -2
Misses 301 301
Partials 50 50
☔ View full report in Codecov by Sentry. |
MetRonnie
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cylc/cylc-admin#182
Added flake8-type-checking library to project and resolved issues it identified.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.