Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that tests against dev versions of upstream packages succeed #203

Closed
krlmlr opened this issue Dec 1, 2019 · 3 comments
Closed

Ensure that tests against dev versions of upstream packages succeed #203

krlmlr opened this issue Dec 1, 2019 · 3 comments
Labels
debt Technical debt
Milestone
0.1.2

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 1, 2019

Tests are active but currently don't lead to a failing build.

https://travis-ci.org/krlmlr/dm/jobs/619326831

See tic.R for a list of GitHub packages to install.
@krlmlr krlmlr added the debt Technical debt label Dec 1, 2019
@krlmlr krlmlr added this to the 0.1.2 milestone Feb 14, 2020
@krlmlr krlmlr modified the milestones: 0.2.0, 0.1.2 Mar 14, 2020
@krlmlr
Copy link
Collaborator Author

krlmlr commented Apr 3, 2020

Still using dbplyr:::test_srcs() which no longer works, how to resolve?

@krlmlr krlmlr modified the milestones: 0.1.2, 0.1.3 Apr 3, 2020
@krlmlr krlmlr modified the milestones: 0.1.3, 0.1.2 Apr 22, 2020
krlmlr added a commit that referenced this issue Apr 23, 2020
@krlmlr
Addresses #203.
2a6246c 
- Implement `pull()`, `group_data()`, `group_indices()`, `group_vars()`, `group_keys()` and `groups()` for `"zoomed_dm"`.
- Fix compatibility with dplyr 1.0.0 (#203).
@krlmlr
Copy link
Collaborator Author

krlmlr commented Apr 30, 2020

Looks much better now.

@krlmlr krlmlr closed this as completed Apr 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2021

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Technical debt
Milestone
0.1.2
Development

No branches or pull requests
1 participant
@krlmlr