Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column renames are not reflected in foreign keys #856

Closed
krlmlr opened this issue Mar 11, 2022 · 1 comment · Fixed by #857
Closed

Column renames are not reflected in foreign keys #856

krlmlr opened this issue Mar 11, 2022 · 1 comment · Fixed by #857
Labels
bug Something isn't working
Milestone

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 11, 2022

Our tests don't catch this, this isn't detected by validate_dm() either.

library(dm)
#> 
#> Attaching package: 'dm'
#> The following object is masked from 'package:stats':
#> 
#>     filter
dm_nycflights13() %>% 
  dm_rename(airports, airport_id = faa) %>% 
  dm_get_all_fks() %>% 
  filter(parent_table == "airports")
#> # A tibble: 1 × 5
#>   child_table child_fk_cols parent_table parent_key_cols on_delete
#>   <chr>       <keys>        <chr>        <keys>          <chr>    
#> 1 flights     origin        airports     faa             no_action

Created on 2022-03-11 by the reprex package (v2.0.1)

@krlmlr krlmlr added the bug Something isn't working label Mar 11, 2022
@krlmlr krlmlr added this to the 0.3.2 milestone Mar 11, 2022
krlmlr added a commit that referenced this issue Mar 14, 2022
- Fix column tracking for foreign keys (#856, #857).
@krlmlr krlmlr modified the milestones: 0.3.2, 0.2.8 Apr 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant