Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify top of README #1066

Merged
merged 7 commits into from
Jun 15, 2022
Merged

docs: simplify top of README #1066

merged 7 commits into from
Jun 15, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented Jun 13, 2022

  • Less to read if not "tl;dr"
  • Some users might be new to the abbreviation RDBMS

@maelle maelle requested a review from krlmlr June 13, 2022 11:23
README.Rmd Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented Jun 13, 2022

Before merging I'll need to know #757 (comment)

(I'll create CONTRIBUTING.md with that piece of info 😸)

dm_nycflights13(cycle = TRUE) %>% dm_draw() %>% DiagrammeRsvg::export_svg() %>% writeLines("logo.svg"), then editing SVG to remove the transparency, and converting to SVG using a web service
pkgdown::build_favicons(overwrite = TRUE)
@krlmlr krlmlr merged commit faa25a2 into main Jun 15, 2022
@krlmlr krlmlr deleted the maelle-patch-1 branch June 15, 2022 01:41
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 15, 2022

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants