Support DuckDB in rows_insert(), rows_update() and rows_delete()
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
Sep 16, 2021
|
Is there an existing DuckDB issue regarding support for CC @hannesmuehleisen. |
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
I didn't find an issue yet and therefore created one: duckdb/duckdb#2291. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting DuckDB in these three functions seems to be pretty easy. Unfortunately, DuckDB doesn't seem to support RETURNING. At least I didn't find in the documentation and got nothing back when I tried it out at first.
I guess that we could also remove
sql_rows_update.tbl_SQLiteConnection()and let SQLite simply usesql_rows_update.tbl_sql(). What do you think?