Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better support for across() #665

Closed
wants to merge 4 commits into from
Closed

better support for across() #665

wants to merge 4 commits into from

Conversation

TSchiefer
Copy link
Member

@TSchiefer TSchiefer commented Oct 13, 2021

The problem was only that we're using enquo() with the option .named = TRUE.
I am already apologizing for the clumsy way of detecting across( with grepl() (which could lead to a problem if someone calls their column weirdly), and I'd be happy to get a pointer here.

I didn't do anything about key tracking, since that will be covered in #663

closes #640

Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we let mutate() and summarize() do their thing (i.e. pass ... without really analyzing them) and track keys after the fact? For summarize() we should really only look for grouped columns, for mutate() we give more responsibility to the user.

@TSchiefer
Copy link
Member Author

That makes sense, in line with #663.

@TSchiefer
Copy link
Member Author

I'll do this in a new PR relating to #663.

@TSchiefer TSchiefer closed this Oct 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make dm_zoom_to work with dplyr's across
2 participants