-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Extract contributor name from PR merge message #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great!
tests/testthat/test-update-news.R
Outdated
withr::local_envvar("FLEDGE_TEST_GITHUB_SLUG" = "cynkra/fledge") | ||
httptest::with_mock_dir("pr", { | ||
withr::local_envvar("GITHUB_PAT" = "ghp_111111111111111111111111111111111111111") | ||
expect_snapshot(extract_newsworthy_items("Merge pull request #18 from someone/conventional-parsing")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect_snapshot(extract_newsworthy_items("Merge pull request #18 from someone/conventional-parsing")) | |
expect_snapshot({ | |
extract_newsworthy_items("Merge pull request #18 from someone/conventional-parsing") %>% | |
jsonlite::toJSON(pretty = TRUE, na = "string") | |
}) |
Maybe worth adding a wrapper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed!! ✨
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
It's a bit surprising to me that adding a helper is needed, but I had no luck with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you please merge when green?
Fix #356
Part of #354