isSleeping() ARP Check Addition and ffMonitor() Updates For Client Broadcasts #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated isSleeping to check the Pi's ARP table for a client's MAC address. If a client's MAC address is present in the ARP table *and* the client has responded to an ICMP ping request in the past 30 seconds, the client is marked as not sleeping. Additionally, added logging statements to record when a client transitions from awake to sleep.
Updated the ffMonitor function to look for "i-can-play-ffm-udp" and "i-cannot-play-ffm-udp" from a client. If either of those broadcast packets are received, we mark the client as awake. This will help with older iOS hardware not responding via ICMP when their CPU gets busy. iOS appears to stop replying to ICMP with high CPU, however packet captures have shown that the ForeFlight heartbeat broadcast packets are still sent during the high CPU times.
This reverts commit 52043b5.
Updated the ffMonitor function to look for "i-can-play-ffm-udp" and "i-want-to-play-ffm-udp" from a client. If either of those broadcast packets are received, we mark the client as awake. This will help with older iOS hardware not responding via ICMP when their CPU gets busy. iOS appears to stop replying to ICMP with high CPU, however packet captures have shown that the ForeFlight heartbeat broadcast packets are still sent during the high CPU times.
|
Will this affect the client sleep stuff? |
|
@Ergonomicmike - I do not believe there will be any difference in behavior between this change and the existing code for sleeping clients. Definitely would appreciate a peer review/testing confirmation of that though. |
|
Just a heads-up, flew about 10 hours these past few weeks and the ADS-B Disconnected messages are still occurring even with this patch, however much less frequently. I would say I have gotten 3 messages in the past 10 flying hours. I have not had time to pull the logs, but will do so and report back. |
|
I wonder how this will do on iOS 11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issue #631
isSleeping() has been updated to check the PI's ARP table to help determine if a client is sleeping or awake. This should help clients that inconsistently reply to ICMP ping requests.
ffMonitor() has been re-activated and modified to update a client's state when the client sends a Foreflight heartbeat packet to broadcast.
Logging messages have been added to help troubleshooting. These messages are controlled via the Verbose Message Logging toggle within the GUI.