Removing CRAM-MD5 mechanism #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
|
@Neustradamus please advise. |
|
@Danelif: I think, you must to look SCRAM before merging: Several PHP projects support already several SCRAM (badly not -PLUS variants). Note: LOGIN is not secure too. |
|
Should i provide an other PR or try to implement SCRAM in the Same PR removing CRAM-MD5 ?? @Neustradamus |
|
@Danelif: Another one :) |
|
ok, but this must not be merged in until stronger SCRAM is available. Many people run Cypht from master, and we release versions from master. |
|
@Danelif Please resolve conflicts. |
|
AFAIK This PR was forbidden by @kroky. He said that removing supported mechanisms was not recommended, so it has to be closed. |
|
Right. So weaker mechanisms are still better than plain password. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove CRAM-MD5 mechanism from cypht
Suggested here: #355