[ENH] Adding SCRAM-SHA authentication mechanisms to cypht #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danelif
force-pushed
the
enh-scram
branch
2 times, most recently
from
92960f9
to
5495ccc
Compare
|
@Neustradamus please advise. |
Danelif
changed the title
Danelif
force-pushed
the
enh-scram
branch
2 times, most recently
from
bc2c3a9
to
e9b85d4
Compare
Danelif
changed the title
|
i just finished adding scram-sha-256 version to the code |
Danelif
changed the title
Danelif
force-pushed
the
enh-scram
branch
2 times, most recently
from
64c9d01
to
d6d6561
Compare
Danelif
changed the title
kroky
reviewed
Jun 11, 2024
kroky
reviewed
Jun 11, 2024
kroky
reviewed
Jun 11, 2024
|
Great you added unit tests! |
kroky
reviewed
Jun 13, 2024
|
@Danelif: Good job! |
|
About SHA3-512/SHA3-512-PLUS, it is not possible to add too? |
|
@Neustradamus It is possible to add SHA3-512/SHA3-512-PLUS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implement SCRAM-SHA-1/512 and SCRAM-SHA-1/512-PLUS authentication mechanisms into cypht
Related issue
Related issue