feat(base): generate new image with version 18.6.0 #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@admah Don't hesitate to tell me if anything is missing. I took the liberty to clean some docs. |
|
@ivangabriele it looks like there are some failures in testing unrelated to this PR, but that we will need to get sorted out before this is merged. Just wanted to give you a heads up. |
|
@admah Thanks for the heads up ^^. I'll rebase this branch once master is ready. |
|
@ivangabriele |
ivangabriele
force-pushed
the
ivan/feat-base-add-new-image-for-node-18-6-0
branch
from
98ab89a
to
b1dacc0
Compare
ivangabriele
force-pushed
the
ivan/feat-base-add-new-image-for-node-18-6-0
branch
from
6fd639e
to
1b84de7
Compare
|
@admah Sorry for the late update! I just rebased ;). I'm not sure why the CI don't run the new generated job, I guess it's because of Github branch protection rules ^^. |
|
I made a new PR since it's easier than resolving conflicts: #738 |
Merged
|
Closing this now that #738 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting #712