BREAKING CHANGE: factory to use nodejs v20 #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/node_20_default_factory_version
branch
from
24499c2
to
fac47ab
Compare
mjhenkes
reviewed
Aug 7, 2023
mjhenkes
approved these changes
Aug 7, 2023
AtofStryker
force-pushed
the
breaking/node_20_default_factory_version
branch
from
70f42b8
to
1b0c59e
Compare
BREAKING CHANGE: the cypress docker factory by default will now use node version 20.5.0. For node 18, please use v2
AtofStryker
force-pushed
the
breaking/node_20_default_factory_version
branch
from
1b0c59e
to
b382970
Compare
mjhenkes
reviewed
Aug 8, 2023
factory/factory.Dockerfile
Outdated
Comment on lines
59
to
60
| openssl \ | ||
| ca-certificates |
There was a problem hiding this comment.
move these to be above the # build only dependancies: removed in onbuild step comment since these aren't removed in the on build. put a comment above them as for why they're needed.
|
Can remove ca-certs install from since it will already have been installed. |
mjhenkes
reviewed
Aug 8, 2023
mjhenkes
reviewed
Aug 8, 2023
mjhenkes
approved these changes
Aug 8, 2023
chrisbreiding
approved these changes
Aug 8, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the cypress docker factory by default will now use node version 20.5.0. For node 18, please use v2
Uses node
v20.5.0by default which is the current node. factoryv2will be used for 18 which is current LTS