Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename configuration option blacklistHosts to blocklistHosts #2861

Merged
merged 12 commits into from Jul 13, 2020
Merged

Rename configuration option blacklistHosts to blocklistHosts #2861

merged 12 commits into from Jul 13, 2020

Conversation

laiscoolblue
Copy link
Contributor

@laiscoolblue laiscoolblue commented Jun 8, 2020 •
edited

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@laiscoolblue laiscoolblue mentioned this pull request Jun 8, 2020
Merged
3 tasks
@jennifer-shehane jennifer-shehane self-requested a review June 9, 2020 03:35
@jennifer-shehane jennifer-shehane marked this pull request as draft June 9, 2020 03:35
jennifer-shehane
jennifer-shehane requested changes Jun 15, 2020
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are referencing the incorrect key. Should be blacklistHosts, not blacklisthosts

cypress.json Outdated Show resolved Hide resolved
source/faq/questions/using-cypress-faq.md Outdated Show resolved Hide resolved
source/guides/references/configuration.md Outdated Show resolved Hide resolved
source/guides/references/configuration.md Outdated Show resolved Hide resolved
laiscoolblue and others added 4 commits June 15, 2020 12:08
@laiscoolblue @jennifer-shehane
Update cypress.json
9c25cc6 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@laiscoolblue @jennifer-shehane
Update source/guides/references/configuration.md
d7f1242 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@laiscoolblue @jennifer-shehane
Update source/faq/questions/using-cypress-faq.md
2c80223 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@laiscoolblue @jennifer-shehane
Update source/guides/references/configuration.md
fa8ccab 
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
@jennifer-shehane jennifer-shehane self-requested a review June 15, 2020 10:12
@jennifer-shehane jennifer-shehane mentioned this pull request Jun 23, 2020
Merged
5 tasks
@jennifer-shehane jennifer-shehane changed the base branch from develop to 5.0.0-release June 23, 2020 05:58
@jennifer-shehane jennifer-shehane mentioned this pull request Jun 24, 2020
Merged
14 tasks
@jennifer-shehane jennifer-shehane marked this pull request as ready for review July 13, 2020 08:46
@jennifer-shehane jennifer-shehane merged commit b6a77ea into cypress-io:5.0.0-release Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laiscoolblue @CLAassistant @jennifer-shehane @hiwanz