Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaced missing font awesome icons #4023

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

robertguss
Copy link
Contributor

While attempting to build and serve a static version of the docs site, several errors appear in the console regarding various font-awesome icons that cannot be found. It looks like some of these icons are referencing an older version of FA. I have replaced them with icons from FA v5 which is what we are currently using.

@robertguss robertguss force-pushed the fix-missing-font-awesome-icons branch from 6b7cad7 to 5db22ee Compare July 14, 2021 14:31
@robertguss robertguss force-pushed the fix-missing-font-awesome-icons branch from 5db22ee to 49077ff Compare July 14, 2021 14:39
@robertguss robertguss marked this pull request as ready for review July 14, 2021 14:42
@robertguss robertguss requested a review from a team July 14, 2021 14:43
Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@admah admah merged commit 682d8b2 into master Jul 14, 2021
@admah admah deleted the fix-missing-font-awesome-icons branch July 14, 2021 14:51
@axolo-co
Copy link

axolo-co bot commented Jul 14, 2021

Axolo's notification on Slack Channel creation

14/07/2021
02:20 PM: axolo axolo has joined the channel

02:20 PM: robert robert has joined the channel

02:20 PM: axolo axolo set the channel topic: Link to PR : #4023

02:42 PM: axolo axolo has renamed the channel from "_pr_draft_fix_replaced_missing_font_awesome_icons" to "_pr_fix_replaced_missing_font_awesome_icons"

02:43 PM: adamm adamm has joined the channel

02:43 PM: amir amir has joined the channel

02:43 PM: bena bena has joined the channel

02:43 PM: kevin kevin has joined the channel

02:43 PM: mike mike has joined the channel

Start of the conversation

14/07/2021
02:20 PM: axolo robertguss just created a pull request

02:43 PM: axolo robertguss asked admah, bahmutov, amirrustam, cowboy, kevinold, mccataldo, robertguss to review fix: replaced missing font awesome icons pull request on cypress-documentation

02:49 PM: axolo 🥳 admah approved this pull request !

02:51 PM: axolo The pull request was closed or merged, congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants