Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNIFY-328 Update all references to config file #4093

Merged
merged 15 commits into from
Sep 24, 2021

Conversation

jaffrepaul
Copy link
Contributor

https://cypress-io.atlassian.net/browse/UNIFY-328

Note:

  • additional tickets to follow based on nuanced refs noted in Jira ticket ☝️ 

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2021

CLA assistant check
All committers have signed the CLA.

content/api/commands/exec.md Outdated Show resolved Hide resolved
@jaffrepaul jaffrepaul marked this pull request as draft September 16, 2021 14:17
@jaffrepaul jaffrepaul force-pushed the update-config-file-references branch 5 times, most recently from 62a49f6 to b49aa93 Compare September 20, 2021 21:44
@jaffrepaul jaffrepaul force-pushed the update-config-file-references branch 2 times, most recently from 7cf2268 to ce5d9a4 Compare September 21, 2021 17:24
@jaffrepaul jaffrepaul marked this pull request as ready for review September 21, 2021 17:27
@jaffrepaul jaffrepaul force-pushed the update-config-file-references branch 2 times, most recently from cea74e9 to d46e00d Compare September 21, 2021 20:36
Update screenshot.md
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaffrepaul there are a lot of tweaks I'd like to see made here. Many are the inclusion of "Cypress" (which is a new thing), but there are also a lot that are fixing issues like duplicate words like "file file," mentioning "configuration file" when the content isn't about the file but just the configuration, and a few examples that just didn't make any sense.

Can you apply these suggestions, in addition to making any changes that I requests as plain text? Thanks!

Comment on lines 82 to 83

#### Return a single configuration option from the [configuration file](/guides/references/configuration) file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Return a single configuration option from the [configuration file](/guides/references/configuration) file

content/api/commands/request.md Outdated Show resolved Hide resolved
content/api/commands/exec.md Outdated Show resolved Hide resolved
content/api/commands/readfile.md Outdated Show resolved Hide resolved
content/api/commands/route.md Outdated Show resolved Hide resolved
content/guides/tooling/reporters.md Outdated Show resolved Hide resolved
content/guides/tooling/reporters.md Outdated Show resolved Hide resolved
content/guides/tooling/reporters.md Outdated Show resolved Hide resolved
content/guides/tooling/reporters.md Outdated Show resolved Hide resolved
content/guides/tooling/reporters.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change!

content/guides/migrating-to-cypress/protractor.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaffrepaul jaffrepaul merged commit c474e3a into new-config Sep 24, 2021
@jaffrepaul jaffrepaul deleted the update-config-file-references branch September 24, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants