Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pact-cypress-adapter #4400

Closed
wants to merge 8 commits into from

Conversation

B3nnyL
Copy link
Contributor

@B3nnyL B3nnyL commented Mar 21, 2022

Pact Cypress Adapter is a collection of cypress commands that generate pact from Cypress test.

@netlify
Copy link

netlify bot commented Mar 21, 2022

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 60827ee

@vercel
Copy link

vercel bot commented Mar 21, 2022

@B3nnyL is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2022

CLA assistant check
All committers have signed the CLA.

@mefellows
Copy link

Hi team - just following up on this PR. Do you need anything else from us to progress it?

@B3nnyL
Copy link
Contributor Author

B3nnyL commented Apr 6, 2022

@elylucas is there anything else required from us?

Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great addition. Thanks!

Copy link
Contributor

@admah admah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed one thing that needs to change. This needs to be listed as a community plugin.

"description": "Simple commands that generates pact from Cypress for pact test",
"link": "https://github.com/pactflow/pact-cypress-adapter",
"keywords": ["pact", "contract testing", "commands"],
"badge": "official"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"badge": "official"
"badge": "community"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout @admah

We've also address a description change we wanted to make, in the following PR #4477

@B3nnyL is based in Aus, so will probably be 💤 :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for her to update the comments and get the full PR glory though 🙌🏾 🚀

@B3nnyL
Copy link
Contributor Author

B3nnyL commented May 16, 2022

@YOU54F thanks! I'll close this PR due to duplication of #4477

@B3nnyL B3nnyL closed this May 16, 2022
@B3nnyL B3nnyL deleted the add-pact-cypress-adapter branch May 16, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants