-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use baseUrl instead of hardcoding port into specs #134
Comments
i went ahead and made a pr #135 with the suggestions above, feel free to do close/merge/whatever! |
@cblgh Thanks for the suggestion! This isn't the first time we have gotten it. This repo serves 2 purposes which makes this change a little bit more work.
The suggestion you made works great for #1, but requires some changes to accommodate #2. For #2, we do not include a We do already have a script written that transforms the The |
alright, in that case i'll go ahead and close it :) |
👋
i'm doing research on frontend testing for the company i work for and i came across Cypress.
i tried to run the kitchen sink testing suite to see it in action, but since it relies on port
8080
being free it broke due to a pre-existing webserver.as a first-timer to the project i was uncertain if there was a port i could set anywhere to have it listen to another webserver, but after some digging it turns out you've just hardcoded the request URLs in the specs.
my suggestion would be
"baseUrl": "http://127.0.0.1:8080/"
incypress.json
baseUrl
should match the url fromnpm run start
's output~cblgh
The text was updated successfully, but these errors were encountered: