chore: fix test flake with shared workers and correlating on failures (…

…#28132) Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
cypress-io · Oct 26, 2023 · 80cc83d · 80cc83d · cypress-bot · Oct 26, 2023
1 parent 15f7300
commit 80cc83d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/packages/server/test/integration/http_requests_spec.js b/packages/server/test/integration/http_requests_spec.js
@@ -1035,7 +1035,7 @@ describe('Routes', () => {
         this.networkProxy.setPreRequestTimeout(50)
         // If this takes longer than the Promise.delay and the prerequest timeout then the second
         // call has hit the prerequest timeout which is a problem
-        this.timeout(150)
+        this.timeout(900)
 
         nock(this.server.remoteStates.current().origin)
         .get('/')
@@ -1057,6 +1057,7 @@ describe('Routes', () => {
 
         // Wait 100 ms to make sure the request times out
         return Promise.delay(100).then(() => {
+          this.networkProxy.setPreRequestTimeout(1000)
           nock(this.server.remoteStates.current().origin)
           .get('/')
           .once()

diff --git a/system-tests/projects/e2e/shared-worker.js b/system-tests/projects/e2e/shared-worker.js
@@ -1,14 +1,14 @@
-// eslint-disable-next-line no-undef
-importScripts('/sw.js')
-
-self.addEventListener('connect', (event) => {
+self.onconnect = (event) => {
   const port = event.ports[0]
 
   port.onmessage = (e) => {
+    // eslint-disable-next-line no-undef
+    importScripts('/sw.js')
+
     if (e.data.foo === 'baz') {
       port.postMessage({
         foo: 'baz2',
       })
     }
   }
-})
+}
diff --git a/system-tests/projects/e2e/web-worker.js b/system-tests/projects/e2e/web-worker.js
@@ -1,7 +1,7 @@
-// eslint-disable-next-line no-undef
-importScripts('/ww.js')
-
 onmessage = (e) => {
+  // eslint-disable-next-line no-undef
+  importScripts('/ww.js')
+
   if (e.data.foo === 'bar') {
     postMessage({
       foo: 'bar2',