Skip to content

Commit

Permalink
fix: make webpack-dev-server a peer dependency (#15163)
Browse files Browse the repository at this point in the history
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
  • Loading branch information
elevatebart and lmiller1990 committed Feb 23, 2021
1 parent ea53307 commit fa969fb
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 4 additions & 0 deletions npm/react/package.json
Expand Up @@ -103,6 +103,7 @@
"peerDependencies": {
"@babel/core": "^=7.x",
"@babel/preset-env": "^=7.x",
"@cypress/webpack-dev-server": "*",
"@types/react": "^16.9.16 || ^17.0.0",
"babel-loader": "^=8.x",
"cypress": "*",
Expand Down Expand Up @@ -141,6 +142,9 @@
"@babel/preset-env": {
"optional": true
},
"@cypress/webpack-dev-server": {
"optional": true
},
"@types/react": {
"optional": true
},
Expand Down
8 changes: 7 additions & 1 deletion npm/vue/package.json
Expand Up @@ -12,7 +12,6 @@
"watch": "tsc -w"
},
"dependencies": {
"@cypress/webpack-dev-server": "0.0.0-development",
"@vue/test-utils": "1.0.3",
"unfetch": "4.1.0"
},
Expand All @@ -21,6 +20,7 @@
"@babel/plugin-transform-modules-commonjs": "7.10.4",
"@babel/preset-env": "7.9.5",
"@cypress/code-coverage": "3.8.1",
"@cypress/webpack-dev-server": "0.0.0-development",
"@intlify/vue-i18n-loader": "1.0.0",
"@vue/cli-plugin-babel": "~4.4.0",
"@vue/cli-service": "~4.4.0",
Expand All @@ -45,6 +45,7 @@
"webpack": "4.42.0"
},
"peerDependencies": {
"@cypress/webpack-dev-server": "*",
"babel-loader": "8",
"cypress": ">=4.5.0",
"vue": "2.x"
Expand All @@ -68,6 +69,11 @@
"cypress",
"vue"
],
"peerDependenciesMeta": {
"@cypress/webpack-dev-server": {
"optional": true
}
},
"publishConfig": {
"access": "public",
"registry": "http://registry.npmjs.org/"
Expand Down

4 comments on commit fa969fb

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fa969fb Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.7.0/circle-develop-fa969fba78d86494b5d920f573768677301fad13/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fa969fb Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 ia32 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.7.0/appveyor-develop-fa969fba78d86494b5d920f573768677301fad13/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fa969fb Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVeyor has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.7.0/appveyor-develop-fa969fba78d86494b5d920f573768677301fad13/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on fa969fb Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/6.7.0/circle-develop-fa969fba78d86494b5d920f573768677301fad13/cypress.tgz

Please sign in to comment.