fix: Use app.quit instead of process.exit to prevent crash on close (#…

…17774)
cypress-io · Aug 17, 2021 · ff33286 · ff33286 · cypress-bot · Aug 17, 2021
1 parent 3973c33
commit ff33286
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/server/lib/modes/interactive-e2e.js b/packages/server/lib/modes/interactive-e2e.js
@@ -18,7 +18,7 @@ module.exports = {
     return os.platform() === 'darwin'
   },
 
-  getWindowArgs (state, options = {}) {
+  getWindowArgs (state) {
     const common = {
       backgroundColor: '#dfe2e4',
       width: state.appWidth || 800,
@@ -51,7 +51,7 @@ module.exports = {
         return Windows.showAll()
       },
       onClose () {
-        return process.exit()
+        app.quit()
       },
     }
 

diff --git a/packages/server/test/unit/modes/interactive_spec.js b/packages/server/test/unit/modes/interactive_spec.js
@@ -25,11 +25,11 @@ describe('gui/interactive', () => {
   })
 
   context('.getWindowArgs', () => {
-    it('exits process when onClose is called', () => {
-      sinon.stub(process, 'exit')
+    it('quits app when onClose is called', () => {
+      electron.app.quit = sinon.stub()
       interactiveMode.getWindowArgs({}).onClose()
 
-      expect(process.exit).to.be.called
+      expect(electron.app.quit).to.be.called
     })
 
     it('tracks state properties', () => {