Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use app.quit instead of process.exit to prevent crash on close #17774

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 17, 2021

User facing changelog

  • Cypress no longer causes a SIGSEGV error on Mac when closing the test runner

Additional details

Using process.exit() doesn't allow time for other handlers and cleanup to run, causing the SIGSEGV error. app.quit() "guarantees that all beforeunload and unload event handlers are correctly executed."

PR Tasks

  • Have tests been added/updated? I updated the unit test, but I don't think there's any way to write an automated test for the actual crashing issue...
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@chrisbreiding chrisbreiding requested a review from a team as a code owner August 17, 2021 17:24
@chrisbreiding chrisbreiding requested review from jennifer-shehane and kuceb and removed request for a team August 17, 2021 17:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 17, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding requested review from flotwig and removed request for kuceb August 17, 2021 17:26
@cypress
Copy link

cypress bot commented Aug 17, 2021



Test summary

4183 0 50 2Flakiness 1


Run details

Project cypress
Status Passed
Commit 5a71130
Started Aug 17, 2021 5:52 PM
Ended Aug 17, 2021 6:02 PM
Duration 09:53 💡
OS Linux Debian - 10.9
Browser Chrome beta 93

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like if we had a better way to test for these crashes ahead of release. Manually tested and is no longer crashing when selecting to close Cypress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress 8.3.0 is crashing while closing test runner window on MacOS
3 participants