Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If DEBUG=cypress variable is set, print NODE_OPTIONS too #1673

Closed
bahmutov opened this issue May 3, 2018 · 1 comment · Fixed by #1675
Closed

If DEBUG=cypress variable is set, print NODE_OPTIONS too #1673

bahmutov opened this issue May 3, 2018 · 1 comment · Fixed by #1675
Assignees
@bahmutov
Labels
cli
Milestone
3.0.0

Comments

@bahmutov
Copy link
Contributor

bahmutov commented May 3, 2018

Node 8.x allows passing node variables via NODE_OPTIONS environment variable (see https://medium.com/the-node-js-collection/node-options-has-landed-in-8-x-5fba57af703d). This can affect Cypress in unexpected ways, including silent fails, like in #1434 (comment)

To allow debugging this, if DEBUG=cypress... is set, we need to print NODE_OPTIONS on startup.
@bahmutov bahmutov self-assigned this May 3, 2018
@bahmutov bahmutov added the cli label May 3, 2018
bahmutov added a commit that referenced this issue May 3, 2018
@bahmutov
cli: print NODE_OPTIONS when DEBUG=cypress... is used, close #1673
0032f0b
@bahmutov bahmutov mentioned this issue May 3, 2018
Merged
jennifer-shehane pushed a commit that referenced this issue May 15, 2018
@bahmutov @jennifer-shehane
cli: print NODE_OPTIONS when DEBUG=cypress... is used, close #1673 (#…
8188a44 
…1675)
@jennifer-shehane jennifer-shehane added this to the 3.0.0 milestone May 15, 2018
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: pending release stage: investigating Someone from Cypress is looking into this stage: needs investigating Someone from Cypress needs to look at this stage: ready for work The issue is reproducible and in scope labels May 24, 2018
@brian-mann
Copy link
Member

Released in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
cli
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

cli: print NODE_OPTIONS when DEBUG=cypress... is used, close #1673 cypress-io/cypress
3 participants
@brian-mann @jennifer-shehane @bahmutov