Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project name in Windows should not be displayed as entire path. #1830

Closed
jennifer-shehane opened this issue May 30, 2018 · 1 comment · Fixed by #1833
Closed

project name in Windows should not be displayed as entire path. #1830

jennifer-shehane opened this issue May 30, 2018 · 1 comment · Fixed by #1833
Assignees
@jennifer-shehane
Labels
OS: windows pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory
Milestone
3.0.2

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

In Windows Desktop-Gui, where in nav bar where project name should be, is displayed as entire path

screen shot 2018-05-30 at 1 14 10 pm

Desired behavior:

Only show current dir as project name in nav bar.

screen shot 2018-05-30 at 1 15 58 pm

Versions

Cypress <=3.0.0
@jennifer-shehane jennifer-shehane self-assigned this May 30, 2018
@jennifer-shehane jennifer-shehane added this to the 3.0.1 milestone May 30, 2018
@jennifer-shehane jennifer-shehane added pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory stage: in progress labels May 30, 2018
jennifer-shehane added a commit that referenced this issue May 30, 2018
@jennifer-shehane
Update project name in nav to display as last dir when in Windows
c866ca5 
- close #1830
@jennifer-shehane jennifer-shehane mentioned this issue May 30, 2018
Merged
@brian-mann brian-mann modified the milestones: 3.0.1, 3.0.2 May 31, 2018
brian-mann pushed a commit that referenced this issue Jun 1, 2018
@jennifer-shehane @brian-mann
Update project name in nav to display as last dir when in Windows (#1833
7d999e0 
)

* Update project name in nav to display as last dir when in Windows

- close #1830

* let -> const

* set project name to projectName when returned from open:project

* Update imported Component name to match exported Component name

* update tests to reflect use of 'projectName' for nav and setup form
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: in progress stage: needs investigating Someone from Cypress needs to look at this stage: proposal 💡 No work has been done of this issue stage: needs review The PR code is done & tested, needs review stage: ready for work The issue is reproducible and in scope labels Jun 27, 2018
@brian-mann
Copy link
Member

Released in 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennifer-shehane jennifer-shehane

Labels
OS: windows pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

Update project name in nav to display as last dir when in Windows cypress-io/cypress
2 participants
@brian-mann @jennifer-shehane