Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cypress/schematic): add headed option and other fixes #21415

Merged
merged 7 commits into from
May 11, 2022

Conversation

admah
Copy link
Contributor

@admah admah commented May 9, 2022

It appears like a large change because I renamed the sandbox app to prepare for multiple version support.

@admah admah requested a review from a team as a code owner May 9, 2022 20:53
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 9, 2022

Thanks for taking the time to open a PR!

@lmiller1990
Copy link
Contributor

@admah you may need to sign in to CircleCI again, or it won't trigger CI to run.

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the headed fix: https://github.com/cypress-io/cypress/pull/21415/files#diff-4ee798fa6c842712558f99121e5b14db00d1410c489de4bb52597724123be34eR11, but where is the code for "custom baseUrl can be specified via configuration in angular.json. More details are in README.md"? I don't see any changes to this meaning.

npm/cypress-schematic/sandbox13/README.md Outdated Show resolved Hide resolved
@admah
Copy link
Contributor Author

admah commented May 10, 2022

@lmiller1990 the code to allow for custom baseUrls is here.

Documentation on how to actually use different baseUrls is here.

@admah admah requested a review from jordanpowell88 May 10, 2022 19:26
@cypress
Copy link

cypress bot commented May 10, 2022



Test summary

5011 0 54 0Flakiness 0


Run details

Project cypress
Status Passed
Commit cd5de9d
Started May 11, 2022 4:25 PM
Ended May 11, 2022 4:37 PM
Duration 12:12 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 self-requested a review May 10, 2022 23:36
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine from what I can see, just need CI to be ✅

@admah admah merged commit 8de7594 into master May 11, 2022
@admah admah deleted the add-headed-option-ng branch May 11, 2022 18:16
tgriesser added a commit that referenced this pull request May 25, 2022
…pack

* develop:
  test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620)
  docs: add "Steps to test" to PR template (#21606)
  feat: (origin) handle waiting for aliased intercepts (#21579)
  fix: handle git watch error (#21600)
  fix: Successfully create new specs files that do not have a known extension (#21593)
  chore: release 9.7.0
  fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588)
  chore: sort the frameworks select dropdown in a more logical way (#21553)
  Trigger Build
  fix: disable ct testing when run via binary (#21540)
  chore: Update Chrome (beta) to 102.0.5005.61 (#21556)
  chore: release @cypress/react-v5.12.5
  fix: add support for Next.js v12.1.6 (#21516)
  chore: release @cypress/schematic-v1.7.0
  feat(cypress/schematic): add headed option and other fixes (#21415)
  chore: release @cypress/vite-dev-server-v2.2.3
  fix: handle specs with white space in vite-dev-server (#21386)
  Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants