-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cypress/schematic): add headed option and other fixes #21415
Conversation
Thanks for taking the time to open a PR!
|
@admah you may need to sign in to CircleCI again, or it won't trigger CI to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the headed
fix: https://github.com/cypress-io/cypress/pull/21415/files#diff-4ee798fa6c842712558f99121e5b14db00d1410c489de4bb52597724123be34eR11, but where is the code for "custom baseUrl can be specified via configuration in angular.json. More details are in README.md"? I don't see any changes to this meaning.
@lmiller1990 the code to allow for custom baseUrls is here. Documentation on how to actually use different baseUrls is here. |
54c85c3
to
e4c0532
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine from what I can see, just need CI to be ✅
…pack * develop: test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620) docs: add "Steps to test" to PR template (#21606) feat: (origin) handle waiting for aliased intercepts (#21579) fix: handle git watch error (#21600) fix: Successfully create new specs files that do not have a known extension (#21593) chore: release 9.7.0 fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588) chore: sort the frameworks select dropdown in a more logical way (#21553) Trigger Build fix: disable ct testing when run via binary (#21540) chore: Update Chrome (beta) to 102.0.5005.61 (#21556) chore: release @cypress/react-v5.12.5 fix: add support for Next.js v12.1.6 (#21516) chore: release @cypress/schematic-v1.7.0 feat(cypress/schematic): add headed option and other fixes (#21415) chore: release @cypress/vite-dev-server-v2.2.3 fix: handle specs with white space in vite-dev-server (#21386) Empty commit
baseUrl
can be specified via configuration inangular.json
. More details are in README.mdrun
in headed mode #21332 -headed
is now a valid option inrun
modeIt appears like a large change because I renamed the sandbox app to prepare for multiple version support.