-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for Next.js v12.1.6 #21516
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - not sure how you figured this out, but 💯
Glad we have a test in the clone PR, too.
@lmiller1990 I did a full reset of a local Next repo to 12.1.5 and traced the changes starting at getNextJsBaseWebpackConfig. They are working on an Edge compiler for "upcoming middleware work". |
…pack * develop: test(launchpad): skip failure due to recaptcha on windows, enable more windows jobs (#21620) docs: add "Steps to test" to PR template (#21606) feat: (origin) handle waiting for aliased intercepts (#21579) fix: handle git watch error (#21600) fix: Successfully create new specs files that do not have a known extension (#21593) chore: release 9.7.0 fix: do not allow experimentalSessionAndOrigin to be available in CT … (#21588) chore: sort the frameworks select dropdown in a more logical way (#21553) Trigger Build fix: disable ct testing when run via binary (#21540) chore: Update Chrome (beta) to 102.0.5005.61 (#21556) chore: release @cypress/react-v5.12.5 fix: add support for Next.js v12.1.6 (#21516) chore: release @cypress/schematic-v1.7.0 feat(cypress/schematic): add headed option and other fixes (#21415) chore: release @cypress/vite-dev-server-v2.2.3 fix: handle specs with white space in vite-dev-server (#21386) Empty commit
User facing changelog
Add support for Next v12.1.6
Additional details
The API for getNextJsBaseWebpackConfig has changed in version 12.1.6 which was causing the resolved webpack config to not be the
client
webpack configuration. Small tweak passing in both options allows support for the new change and backwards compatibility.How has the user experience changed?
CT testing works with latest version on Next
Testing
I have a clone of this PR targeting 10.0-release that has e2e tests covering this new version of Next.
#21515
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?