Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for non-operational CI provider "Shippable" #26253

Closed
MikeMcC399 opened this issue Mar 28, 2023 · 2 comments
Closed

Remove support for non-operational CI provider "Shippable" #26253

MikeMcC399 opened this issue Mar 28, 2023 · 2 comments
Labels
E2E Issue related to end-to-end testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: chore Work is required w/ no deliverable to end user

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Mar 28, 2023

What would you like?

Remove redundant code in:

and other repositories owned by https://github.com/cypress-io/

which supported the CI provider "Shippable".

Why is this needed?

The provider is no longer operating and the CI domain https://app.shippable.com which was previously hosting https://app.shippable.com/github/cypress-io/cypress-example-kitchensink no longer exists.

Removing the code is a clean-up activity.

Background

The former CI provider "Shippable" no longer provides a service.

Related PRs

@nagash77 nagash77 added type: chore Work is required w/ no deliverable to end user routed-to-e2e labels Mar 28, 2023
@nagash77 nagash77 added E2E Issue related to end-to-end testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed routed-to-e2e labels Apr 19, 2023
@jennifer-shehane
Copy link
Member

@MikeMcC399 We’re open to a PR to clean this up in Cypress.

@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Oct 5, 2023

Considering that the latest releases of the following npm modules used by Cypress 13.3.0 continue to list "Shippable" as an active CI provider, it may generate unexpected problems to remove Shippable from the Cypress code base. The potential risk does not justify the benefits of a clean-up attempt in this case, since the continued presence of the "Shippable" code in Cypress is not known to generate any issues.

Module Cypress uses
ci-info@3.9.0 3.8.0
is-ci@3.0.1 3.0.1

Additionally used in the Cypress repo by semantic-release@19.0.3:

Module Cypress uses
env-ci@10.0.0 5.0.2
@npmcli/ci-detect@3.0.2 2.0.0

(@npmcli/ci-detect is deprecated and replaced by ci-info)

Closing this issue.

Edit: ci-info@4.0.0 removed "Shippable CI".

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Issue related to end-to-end testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: chore Work is required w/ no deliverable to end user
Projects
None yet
Development

No branches or pull requests

3 participants