Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unreachable CI provider "Shippable" #601

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Mar 26, 2023

This PR removes the obsolete CI provider "Shippable" from being displayed in README.md. No CI results can be displayed from "Shippable" since it is no longer operating.

Background

The former CI provider "Shippable" no longer provides a service.

Further suggested fixes

  1. Remove the reference to shippable.yml in Cypress documentation: CI Provider Examples - Remove obsolete CI provider "shippable" from CI example list cypress-documentation#5145
  2. Remove the workflow shippable.yml from this repository

Follow-on suggested (breaking) changes

After implementing the previous suggestions, the next steps would be:

  1. Remove the orphaned workaround for issue cy.exec does not work on Shippable CI when using our cypress/base image cypress#6718 from cypress/e2e/2-advanced-examples/misc.cy.js in this repository and merge into Cypress
  2. Remove the support for "Shippable" as CI provider from Core Cypress

Removing functionality is a breaking change, even though it should theoretically have no practical impact, since "Shippable" is no longer operating. This would probably need to wait until a future suitable major release of Cypress is planned.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 26, 2023 16:59
@MikeMcC399
Copy link
Contributor Author

All tests are passing, except the Azure jobs which fails due to

Your Record Key $(CYP..._KEY) is not valid with this projectId: 4b7344

It may have been recently revoked by you or another user.

Please log into Cypress Cloud to see the valid Record Keys.

https://on.cypress.io/dashboard/projects/4b7344

This is an issue with submitting a PR from a fork, not an issue with the contents of the PR itself.

@lmiller1990
Copy link
Contributor

Thanks for this. I agree those breaking changes are not really breaking, but also no rush to remove the associated code.

Let's merge this, thanks!

@lmiller1990 lmiller1990 merged commit 222fa40 into cypress-io:master Mar 28, 2023
@MikeMcC399 MikeMcC399 deleted the remove/shippable-readme branch March 28, 2023 04:28
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants