Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding build-prod tasks to all of the npm dependencies that need artifacts #9045

Merged
merged 1 commit into from Oct 30, 2020

Conversation

JessicaSachs
Copy link
Contributor

There was a bug in the release process where:

  1. a change was made where the build-prod task was run instead of the build task, so nothing was building
  2. also we weren't waiting for the builds to pass before releasing

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 30, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 30, 2020



Test summary

8639 0 124 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 5f3796e
Started Oct 30, 2020 3:46 PM
Ended Oct 30, 2020 3:58 PM
Duration 12:33 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@JessicaSachs
Copy link
Contributor Author

We're breaking our own build because we broke our dependent packages.

@JessicaSachs JessicaSachs merged commit 550c05c into develop Oct 30, 2020
@JessicaSachs JessicaSachs deleted the fix/disted-dirs-for-release branch October 30, 2020 16:27
@JessicaSachs JessicaSachs restored the fix/disted-dirs-for-release branch October 30, 2020 16:42
@JessicaSachs JessicaSachs deleted the fix/disted-dirs-for-release branch October 30, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@cypress/webpack-preprocessor latest version appears not to have dist directory
2 participants