Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@cypress/webpack-preprocessor latest version appears not to have dist directory #9037

Closed
lmiller1990 opened this issue Oct 30, 2020 · 4 comments · Fixed by #9045
Closed

@cypress/webpack-preprocessor latest version appears not to have dist directory #9037

lmiller1990 opened this issue Oct 30, 2020 · 4 comments · Fixed by #9045
Labels
npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues type: bug

Comments

@lmiller1990
Copy link
Contributor

Current behavior

@cypress/webpack-preprocessor@5.4.9 (latest one) does not have dist directory as specified in main. Cannot be used.

Desired behavior

Deploy a new version with dist correctly built.

Test code to reproduce

yarn add @cypress/webpack-preprocessor

Then just do ls node_modules/@cypress/webpack-preprocessor and see no dist is there.

Versions

5.4.9.
@jennifer-shehane jennifer-shehane added the npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues label Oct 30, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Oct 30, 2020
@cexbrayat
Copy link
Contributor

@lmiller1990 You beat me to it :) I'm encountering the same issue.

It looks like @JessicaSachs already fix it in #9035 just after the release.

@csvan
Copy link

csvan commented Oct 30, 2020

As a temporary measure, you can lock your dependencies to 5.4.8

"@cypress/webpack-preprocessor": "5.4.8"

@JessicaSachs JessicaSachs mentioned this issue Oct 30, 2020
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 30, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 30, 2020

The code for this is done in cypress-io/cypress#9045, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Oct 30, 2020
@JessicaSachs
Copy link
Contributor

JessicaSachs commented Oct 30, 2020 •
edited
Loading

This is fixed in the latest webpack preprocessor version: "@cypress/webpack-preprocessor": "5.4.10"

We had an issue in our build process with semantic release.

@henrik242 henrik242 mentioned this issue Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adding build-prod tasks to all of the npm dependencies that need artifacts cypress-io/cypress
5 participants
@cexbrayat @csvan @jennifer-shehane @JessicaSachs @lmiller1990