Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding build-prod tasks to all of the npm dependencies that need artifacts #9045

Merged
merged 1 commit into from
Oct 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ cli/visual-snapshots
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff
.idea
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/**/usage.statistics.xml
Expand Down
3 changes: 2 additions & 1 deletion npm/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "dist",
"scripts": {
"build": "rimraf dist && yarn transpile && yarn transpile:bin && yarn build:dist-package",
"build-prod": "yarn build",
"build:dist-package": "node scripts/prepareDistPackage.js && ncp ./plugins ./dist/plugins",
"check:links": "find . -type f -name 'README.md' ! -path './node_modules/*' | xargs -L1 npx markdown-link-check --quiet",
"cy:open": "node ../../scripts/cypress open",
Expand Down Expand Up @@ -131,7 +132,7 @@
},
"homepage": "https://on.cypress.io/component-testing",
"author": "Gleb Bahmutov <gleb.bahmutov@gmail.com>",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=JessicaSachs&labels=experiment%3A+component+testing,npm%3A%20%40cypress%2Freact&template=bug-report.md",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Freact&template=1-bug-report.md&title=",
"keywords": [
"react",
"cypress",
Expand Down
3 changes: 2 additions & 1 deletion npm/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"main": "dist/index.js",
"scripts": {
"build": "tsc",
"build-prod": "yarn build",
"build:watch": "tsc --watch",
"cy:open": "node ../../scripts/cypress open",
"cy:run": "node ../../scripts/cypress run",
Expand Down Expand Up @@ -66,7 +67,7 @@
},
"homepage": "https://on.cypress.io/component-testing",
"author": "Gleb Bahmutov <gleb.bahmutov@gmail.com>",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=JessicaSachs&labels=experiment%3A+component+testing,npm%3A%20%40cypress%2Fvue&template=bug-report.md",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fvue&template=1-bug-report.md&title=",
"keywords": [
"cypress",
"vue"
Expand Down
2 changes: 1 addition & 1 deletion npm/webpack-preprocessor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
},
"homepage": "https://github.com/cypress-io/cypress/tree/master/npm/webpack-preprocessor#readme",
"author": "Chris Breiding <chris@cypress.io>",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A %40cypress%2Fwebpack-preprocessor&template=bug-report.md",
"bugs": "https://github.com/cypress-io/cypress/issues/new?assignees=&labels=npm%3A%20%40cypress%2Fwebpack-preprocessor&template=1-bug-report.md&title=",
"keywords": [
"cypress",
"cypress-plugin",
Expand Down
2 changes: 1 addition & 1 deletion scripts/npm-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const waitOnTests = async (names, packageInfo) => {
console.log(`\nWaiting on the following CI jobs: ${jobs.join(', ')}`)

return Promise.all(jobs.map((job) => {
waitForJobToPass(job)
return Promise.resolve(waitForJobToPass(job))
.timeout(minutes(60))
.then(() => {
console.log(`${job} passed`)
Expand Down