Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Node 8.2.1 to build binary on Windows CI #1390 #1391

Merged
merged 12 commits into from
Feb 28, 2018

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Feb 28, 2018

  • appveyor
  • buildkite
  • check the current Node major against .node-version file

@brian-mann
Copy link
Member

So this doesn't happen again... can we add a script that checks the system node matches the .node-version file in the root of the repo?

That way if we do change it but forget to update the system it'll instantly point that out. I know we don't always use exactly 8.2.1 but maybe the script can use semver and sync up the major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants