fix: improve decoding of special chars in source paths

[panzarino]

• Closes Studio unable to save to files with special characters in path #14659

User facing changelog

Fixes issues where special characters in file names would not be decoded correctly.

Additional details

This improves the display of file names in the codeframe and stack trace. In addition, it fixes the Open In IDE button for these specs and allows Studio to properly save to these files.

How has the user experience changed?

For a file named cypress/integration/spec%with space &^$ emoji👍_你好.js

Previous code frame:

New code frame:

In addition to fixing the display, opening in ide and saving to file in studio now also work.

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

9266 • 0 • 118 • 3 • 1

---

Run details

Project	cypress
Status	Passed
Commit	f132959
Started	Jan 22, 2021 1:45 AM
Ended	Jan 22, 2021 1:58 AM
Duration	12:54 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

Nice. I appreciate the thorough comments. I manually tested the Studio and IDE opening with files with special characters and it works fine.

Files with % character in them don't even open in the TR. The code is fine covering this but I don't think this is an actual use case until we fix that.

[jennifer-shehane]

Ignore percy snapshots - going to fix flake in #14687

[panzarino]

@jennifer-shehane Are you sure that's not just an empty test file? The screenshots that I provided in the initial comment show an example of a spec with % in the title.

Looks like e2e tests are legitimately failing so I'll have to figure out why before this can be merged.

[jennifer-shehane]

lol. yeah, I did not read the error message 🙈

[panzarino]

@jennifer-shehane Could you check out the failing e2e tests? I've rerun them a couple times and they continue to fail which indicates its not flake but they're passing locally for me.

[jennifer-shehane]

@panzarino Didn't they pass this time? I think it's that new stdio PR introducing flake. :/

[panzarino]

@jennifer-shehane Yup - probably flake so I'm gonna go ahead and merge