-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add autoEnd option to Cypress.Log Typescript definitions #15076
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing this
Awesome, thanks for the quick turnaround on the PR! |
@bahmutov hi! Sorry just realized that I made a mistake, I guess that's what happens when you think you can do a quick "typo-ish" contribution without reading the guidelines, this was PRed into master, not develop, which I can see in the contribution guidelines is the "production branch", so not sure what the best remedy is there, my bad! |
Ughh I missed it too. Will handle it tomorrow
…Sent from my iPhone
On Feb 12, 2021, at 20:03, Emil Goldsmith Olesen ***@***.***> wrote:
@bahmutov hi! Sorry just realized that I made a mistake, I guess that's what happens when you think you can do a quick "typo-ish" contribution without reading the guidelines, this was PRed into master, not develop, which I can see in the contribution guidelines is the "production branch", so not sure what the best remedy is there, my bad!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Thank you! Will make sure to read the contribution guidelines thoroughly if I help out another time! |
#15087) Co-authored-by: Emil Goldsmith Olesen <emilgoldsmith94@gmail.com>
Sorry if not respecting the contribution guidelines, but this is an issue/PR as I noticed the autoEnd option isn't in the typescript definitions for Cypress, and it was referenced in the webcast on Youtube by the Cypress team: https://www.youtube.com/watch?v=V-o8WzlwKmM
Tried adding it here with a sensible comment, does it look good?
EDIT: Unlazied myself and searched the issues and see that there's #9590 and actually also already a PR for this at #14220 but it seems like this PR is inactive? So I'll keep this up?
closes #9590 (though it doesn't address the lack of documentation)