Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add types for selector playground #15834

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Apr 6, 2021

Adds missing types for selector playground

Note: looks a little different than our other dom signatures that accept either a jquery or html element - selector playground getSelector actually only works with jquery element

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@panzarino panzarino requested a review from a team as a code owner April 6, 2021 23:22
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 6, 2021



Test summary

9494 0 111 3Flakiness 0


Run details

Project cypress
Status Passed
Commit 3b4bca5
Started Apr 13, 2021 7:45 PM
Ended Apr 13, 2021 8:00 PM
Duration 14:33 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino requested review from chrisbreiding and removed request for jennifer-shehane April 12, 2021 21:00
@panzarino panzarino merged commit 98f48ab into develop Apr 13, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2021
@emilyrohrbough emilyrohrbough deleted the add-selector-playground-type branch August 1, 2024 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants