Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move server e2e tests to system-tests #16354

Merged
merged 95 commits into from
Oct 18, 2021
Merged

Conversation

JessicaSachs
Copy link
Contributor

@JessicaSachs JessicaSachs commented May 5, 2021

Additional details

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@JessicaSachs JessicaSachs requested a review from a team as a code owner May 5, 2021 18:25
@JessicaSachs JessicaSachs requested review from flotwig and chrisbreiding and removed request for a team May 5, 2021 18:25
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 5, 2021

Thanks for taking the time to open a PR!

@JessicaSachs JessicaSachs marked this pull request as draft May 5, 2021 18:29
@cypress
Copy link

cypress bot commented May 5, 2021



Test summary

18552 0 214 7Flakiness 1


Run details

Project cypress
Status Passed
Commit 3bd122a
Started Oct 18, 2021 7:39 PM
Ended Oct 18, 2021 7:52 PM
Duration 13:28 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

lmiller1990 commented May 6, 2021

Cool @JessicaSachs. Excited for this. Can you give a hint at what file(s) to review, or how we can write a system test for a CT project? With 600+ files changed, it's hard to know where to start looking. Is there any high-priority-must-review files?

@flotwig flotwig marked this pull request as ready for review October 14, 2021 21:28
chrisbreiding
chrisbreiding previously approved these changes Oct 18, 2021
@flotwig flotwig merged commit a045e4f into develop Oct 18, 2021
@flotwig flotwig deleted the jess/server-tests branch January 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants