-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server-ct): support exclusive inline config #16468
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we deprecating componentFolder
? Seems like we should do that soon, rather than fixing bugs with it
I think we are @agg23, but what will take it's place when when is not clear. Since it could be months before it is deprecated, this fix is worth having - especially considering it's a breaking change (this was working pre 7.0).
|
User facing changelog
Correctly use
componentFolder
andtestFiles
values from returned from plugins in component testing runner.I added a test project, but this does not run on CI. It will once #16354 is merged.
I tested in manually by doing
cd packages/server-ct/test/fixtures/projects/inline-config-only
and runningyarn cy:open
. It found the component and spec files correctly.Additional details
We were the resolved values for
testFiles
andcomponentFolder
as specified incypress.json
. If you specified different values in the config returned fromplugins
, they were not used. We should be using the resolved values.How has the user experience changed?
Allow customizing
testFiles
andcomponentFolder
by returning a config object in plugins.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?