-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add code signing certificate details for Windows build #16670
Conversation
Thanks for taking the time to open a PR!
|
Part of cypress-io#2543 [build binary]
@minijus What is the actual experience when trying to install Cypress on a Windows machine that requires code signing? I'm curious to see how this is directly affecting people with these settings. Do you see an error during install? Is it a strange state the app gets in? |
In organisations that control what can be launched on Windows there are different ways to control allowed list of applications:
Answering your questions - there is no error during installation as technically there is no installation, it is just download of executable. However, launching cypress ( |
What does this look like exactly? Are there errors when it is opened? Is the app in a state that is unusual? I want to be able to recognize this state, in case people don't understand that the Cypress executable is blocked and can't express that this is the problem with opening Cypress. |
@minijus Thanks for providing this, it will help us in assessing prioritizing work for this issue. |
@minijus As an update, I am working on obtaining a code signing certificate, once I have that I will fork your PR so that we can run the full Cypress CI pipeline (w/ secrets) against it and ensure that the distributables are signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #2543
Pull Requests attempts to add environment options required to build signed Windows executable.
Core Cypress team should: