Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure to go back to no-specs when delete spec file #17760

Merged
merged 5 commits into from
Oct 28, 2021
Merged

fix: make sure to go back to no-specs when delete spec file #17760

merged 5 commits into from
Oct 28, 2021

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Aug 17, 2021 •
edited
Loading

Closes #16553

User facing changelog

In CT when deleting/renaming the spec file we are on, instead of erroring, we roll back to the welcome page.

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

To test

run

yarn workspace @packages/runner-ct cypress:open
touch packages/runner-ct/cypress/components/test.spec.tsx
  • then click on the new test.spec.tsx
  • and finally, delete the created file.
  • the page should go back to the "no spec selected"

@elevatebart elevatebart requested a review from a team as a code owner August 17, 2021 02:45
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 17, 2021

Thanks for taking the time to open a PR!

@elevatebart elevatebart requested review from chrisbreiding and jennifer-shehane and removed request for a team August 17, 2021 02:45
@elevatebart elevatebart marked this pull request as draft August 17, 2021 02:55
@cypress
Copy link

cypress bot commented Aug 17, 2021 •
edited
Loading


Test summary

18571 • 1 • 214 • 7 • Flakiness 6

Run details
Project cypress
Status Failed
Commit 4094785
Started Oct 28, 2021 1:27 AM
Ended Oct 28, 2021 1:44 AM
Duration 16:51 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

cypress/integration/commands/navigation_spec.js 1 Failed
1 ... > throws when qs is foo

Flakiness

commands/net_stubbing_spec.ts 1 Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
commands/navigation_spec.js 1 Flakiness
1 src/cy/commands/navigation > #visit > window immediately resolves and doesn't reload when visiting the same URL with hashes
commands/xhr_spec.js 1 Flakiness
1 ... > can alias a route without stubbing it
cypress/proxy-logging-spec.ts 2 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
2 Proxy Logging > request logging > xhr log has response body/status code
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart marked this pull request as ready for review August 17, 2021 03:01
lmiller1990
lmiller1990 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out, works great!

@lmiller1990 lmiller1990 merged commit 6d6623c into develop Oct 28, 2021
@lmiller1990 lmiller1990 deleted the fix/rename-delete-spec branch October 28, 2021 01:48
@cypress-bot cypress-bot bot mentioned this pull request Oct 28, 2021
Closed
@lmiller1990 lmiller1990 restored the fix/rename-delete-spec branch October 28, 2021 01:48
tgriesser added a commit that referenced this pull request Nov 3, 2021
@tgriesser
Merge branch 'develop' into unified-desktop-gui
cc98a30 
* develop: (40 commits)
  fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to (#18441)
  chore: make `create` function on server.ts obsolete (#18615)
  docs: Add instructions to squash commits to develop in Contributing (#18728)
  fix(@cypress/react): throw if using Next.js swc-loader without nodeVersion=system (#18686)
  refactor: remove Ramda (#18723)
  chore: Increase paralleled machines for desktop-gui tests (#18725)
  chore: Update Chrome (stable) to 95.0.4638.69 (#18696)
  chore: release @cypress/vue-v3.0.4
  chore: release @cypress/react-v5.10.2
  chore: release @cypress/schematic-v1.5.3
  fix: remove outdated registry link (#18710)
  chore: release @cypress/schematic-v1.5.2
  chore: release create-cypress-tests-v1.1.3
  chore: Update Chrome (beta) to 96.0.4664.27 (#18676)
  chore(tests): Remove flaky assertion that relies on png how compression (#18668)
  fix: make sure to go back to no-specs when delete spec file (#17760)
  fix: Next.JS 12 components testing failing with ` TypeError: Cannot read property 'traceChild' of undefined` (#18648)
  Backport .gitignore from unified-desktop-gui
  chore(docs): add 'Upgrading Electron' instructions (#18594)
  release 8.7.0 [skip ci]
  ...
tgriesser added a commit that referenced this pull request Nov 3, 2021
@tgriesser
Merge branch 'develop' into unified-desktop-gui
6a9f5a1 
* develop: (40 commits)
  fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to (#18441)
  chore: make `create` function on server.ts obsolete (#18615)
  docs: Add instructions to squash commits to develop in Contributing (#18728)
  fix(@cypress/react): throw if using Next.js swc-loader without nodeVersion=system (#18686)
  refactor: remove Ramda (#18723)
  chore: Increase paralleled machines for desktop-gui tests (#18725)
  chore: Update Chrome (stable) to 95.0.4638.69 (#18696)
  chore: release @cypress/vue-v3.0.4
  chore: release @cypress/react-v5.10.2
  chore: release @cypress/schematic-v1.5.3
  fix: remove outdated registry link (#18710)
  chore: release @cypress/schematic-v1.5.2
  chore: release create-cypress-tests-v1.1.3
  chore: Update Chrome (beta) to 96.0.4664.27 (#18676)
  chore(tests): Remove flaky assertion that relies on png how compression (#18668)
  fix: make sure to go back to no-specs when delete spec file (#17760)
  fix: Next.JS 12 components testing failing with ` TypeError: Cannot read property 'traceChild' of undefined` (#18648)
  Backport .gitignore from unified-desktop-gui
  chore(docs): add 'Upgrading Electron' instructions (#18594)
  release 8.7.0 [skip ci]
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@JessicaSachs JessicaSachs Awaiting requested review from JessicaSachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CT: When the spec file I am on is deleted/renamed I would like to avoid having to reload the whole app
2 participants
@elevatebart @lmiller1990