-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: normalized signatures webpack & vite servers #18379
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see one minor change. Also, this PR is missing tests. Can you add them?
@elevatebart what is the plan for testing these changes? It would be good to get them merged in, but I'm hesitant to approve the PR if there are no tests being added to assert the new changes are correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand the tests, but as long as they give you confidence, 👍🏻 . Only a few other questions to be answered or addressed.
User facing changelog
In preparation for new plugins syntax, add the needed signatures to vite and webpack dev server
Additional details
https://www.notion.so/cypressdx/Dev-server-module-signatures-exports-db9cf2518a1b485a9672811f3e895de7