feat(graphql): ability to update/query for appData

[lmiller1990]

Make the GraphQL interface for access/updating local preferences more generic.

# query
{
  localSettings {
    preferences {
      isSpecsListOpen
    }
  }
}

# update
mutation M {
  # value is JSON.stringify({ k1: value1, k1: value2, ... })
  setPreferences(value: "{ \"isSpecsListOpen\": true }")
}

Typing the setPreferences mutation might be good but it seems a bit complex, and might not make sense since a lot of the fields we cache will either go away, or change, so I just set it to take an object which is JSON.stringified. This is how the current save state API works.

It also improves the types for local data. I hope to make these more strict as we go.

I also added a missing feature which is "open config in editor" since we needed that and it will use a lot of this functionality (eg, we need to set the correct preferred editor if they don't have one). Here is a demo (shows that the localSettings feature is working correctly, too):

democonfig.mov

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

18145 • 0 • 202 • 0 • 5

---

Run details

Project	cypress
Status	Passed
Commit	be5e79a
Started	Nov 29, 2021 12:38 PM
Ended	Nov 29, 2021 12:50 PM
Duration	12:04 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	commands/net_stubbing_spec.ts		3
1	network stubbing > intercepting request > can delay and throttle a StaticResponse
2	network stubbing > waiting and aliasing > can timeout waiting on a single response using "alias.response"
3	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
	cypress/proxy-logging-spec.ts		2
1	Proxy Logging > request logging > xhr log has response body/status code
2	... > works with forceNetworkError

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[marktnoonan]

I think one change is needed for the default values for the preference to survive the initialization, otherwise this works great.

[marktnoonan]

Should we add a description for this mutation? And it's not touched in this PR, but we should update the description of the localSettings field as well since it is still referencing just editors.

[lmiller1990]

Updated, good catch

[marktnoonan]

It looks like these defaults will always be overwritten by the call to actions.localSettings.refreshLocalSettings that happens in initializeData and so don't end up available in what is exposed via qgl.

Should refreshLocalSettings be updated to merge the preferences it finds on the device with the defaults set here, instead of fully replacing the preferences? Unless there's a different purpose for these defaults that I'm not seeing.

[lmiller1990]

Good point... updated to set defaults in the same place as we load the settings. Local preferences will override defaults.

[lmiller1990]

6b83406

[marktnoonan]

Looks good, I pushed 1 commit for an out of date description.