Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve runnable spec on browser change #19290

Merged

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Dec 7, 2021

Fix for preserving the currently selected spec when switching browsers. The backend redirects the browser when switching types and thus requires the exact route that the frontend uses for running a spec.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 7, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 7, 2021



Test summary

18147 0 202 0Flakiness 5


Run details

Project cypress
Status Passed
Commit 94e2759
Started Dec 7, 2021 3:26 PM
Ended Dec 7, 2021 3:37 PM
Duration 11:44 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
2 ... > works with forceNetworkError
3 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart merged commit d5a0175 into elevatebart/fix/nav-bar Dec 7, 2021
@elevatebart elevatebart deleted the fix-browser-change-preserve-spec branch December 7, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants