Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use CYPRESS_VERIFY_TIMEOUT as integer #19517

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

tbiethman
Copy link
Contributor

User facing changelog

  • CYPRESS_VERIFY_TIMEOUT is now used as an integer rather than a string

Additional details

This change allows the CYPRESS_VERIFY_TIMEOUT environment variable to work appropriately when set by the user. The test cases were also updated to be more strict in their assertions.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@tbiethman tbiethman self-assigned this Jan 3, 2022
@tbiethman tbiethman requested a review from a team as a code owner January 3, 2022 12:49
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 3, 2022

Thanks for taking the time to open a PR!

@tbiethman tbiethman requested review from jennifer-shehane and removed request for a team and jennifer-shehane January 3, 2022 12:49
@cypress
Copy link

cypress bot commented Jan 3, 2022



Test summary

18917 0 218 0Flakiness 1


Run details

Project cypress
Status Passed
Commit faf502f
Started Jan 3, 2022 2:52 PM
Ended Jan 3, 2022 3:04 PM
Duration 11:59 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants