chore: fix cypress npm package artifact upload path

[emilyrohrbough]

• Closes The cypress release process has the possibility to generate a package with a bin file with windows line endings. #19771

The upload-npm-package and upload-unique-bindary scripts are aligned with this changes into a single scripts upload-build-artifacts.

User facing changelog

n/a

How has the user experience changed?

Ensures cypress npm package is distributed with the correct line endings.

PR Tasks

• Have tests been added/updated?
• [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?
• [n/a] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[emilyrohrbough]

This image should be updated (show incorrect npm package path). How do you upload to https://user-images.githubusercontent.com?

[flotwig]

Those are from pasting in GitHub comments, but maybe it would be better if they were in the repo itself. You can add the image in /assets or /guides/images or something.

[cypress]

---

Test summary

19177 • 0 • 218 • 0 • 1

---

Run details

Project	cypress
Status	Passed
Commit	aca2e18
Started	Feb 4, 2022 5:03 PM
Ended	Feb 4, 2022 5:14 PM
Duration	11:51 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/commands/net_stubbing_spec.ts		1
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

It seems like getBinaryUrlFromPrereleaseNpmUrl needs to be updated in the CLI, so install can discover the correct binary .zip for a given prerelease .tgz.

cypress/cli/lib/tasks/install.js

Lines 90 to 111 in e2f0a66

	// convert a prerelease NPM package .tgz URL to the corresponding binary .zip URL
	const getBinaryUrlFromPrereleaseNpmUrl = (npmUrl) => {
	let parsed
	try {
	parsed = url.parse(npmUrl)
	} catch (e) {
	return
	}
	const matches = betaNpmUrlRe.exec(parsed.pathname)
	if (parsed.hostname !== 'cdn.cypress.io' || !matches) {
	return
	}
	const { version, artifactSlug } = matches.groups
	parsed.pathname = `/beta/binary/${version}/${os.platform()}-${os.arch()}/${artifactSlug}/cypress.zip`
	return parsed.format()
	}

➜  ~ npm install -g https://cdn.cypress.io/beta/npm/9.4.2/linux-x64/circle-fix-ci-artifact-uploads-403552989ac9ba5e9547ab56b7d58ee65b8b5502/cypress.tgz
npm ERR! code 1
npm ERR! path /home/flotwig/.nvm/versions/node/v16.5.0/lib/node_modules/cypress
npm ERR! command failed
npm ERR! command sh -c node index.js --exec install
npm ERR! ⚠ Warning: Forcing a binary version different than the default.
npm ERR! 
npm ERR!   The CLI expected to install version: 9.4.2
npm ERR! 
npm ERR!   Instead we will install version: https://cdn.cypress.io/beta/binary/9.4.2/linux-x64/linux-x64/circle-fix-ci-artifact-uploads-403552989ac9ba5e9547ab56b7d58ee65b8b5502/cypress.zip
npm ERR! 
npm ERR!   These versions may not work properly together.
npm ERR! 
npm ERR! Installing Cypress (version: https://cdn.cypress.io/beta/binary/9.4.2/linux-x64/linux-x64/circle-fix-ci-artifact-uploads-403552989ac9ba5e9547ab56b7d58ee65b8b5502/cypress.zip)
npm ERR! 
npm ERR! [STARTED] Task without title.
npm ERR! The Cypress App could not be downloaded.
npm ERR! 
npm ERR! Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration
npm ERR! 
npm ERR! Otherwise, please check network connectivity and try again:
npm ERR! 
npm ERR! ----------
npm ERR! 
npm ERR! URL: https://cdn.cypress.io/beta/binary/9.4.2/linux-x64/linux-x64/circle-fix-ci-artifact-uploads-403552989ac9ba5e9547ab56b7d58ee65b8b5502/cypress.zip
npm ERR! Error: Failed downloading the Cypress binary.
npm ERR! Response code: 404
npm ERR! Response message: Not Found
npm ERR! 
npm ERR! ----------
npm ERR! 
npm ERR! Platform: linux-x64 (Ubuntu - )
npm ERR! Cypress Version: 9.4.2
npm ERR! [FAILED] The Cypress App could not be downloaded.
npm ERR! [FAILED] 
npm ERR! [FAILED] Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration
npm ERR! [FAILED] 
npm ERR! [FAILED] Otherwise, please check network connectivity and try again:
npm ERR! [FAILED] 
npm ERR! [FAILED] ----------
npm ERR! [FAILED] 
npm ERR! [FAILED] URL: https://cdn.cypress.io/beta/binary/9.4.2/linux-x64/linux-x64/circle-fix-ci-artifact-uploads-403552989ac9ba5e9547ab56b7d58ee65b8b5502/cypress.zip
npm ERR! [FAILED] Error: Failed downloading the Cypress binary.
npm ERR! [FAILED] Response code: 404
npm ERR! [FAILED] Response message: Not Found
npm ERR! [FAILED] 
npm ERR! [FAILED] ----------
npm ERR! [FAILED] 
npm ERR! [FAILED] Platform: linux-x64 (Ubuntu - )
npm ERR! [FAILED] Cypress Version: 9.4.2

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/flotwig/.npm/_logs/2022-02-03T16_57_31_125Z-debug.log

[flotwig]

nice!