chore: set up semantic-pull-request GitHub Action #20091
Conversation
|
Thanks for taking the time to open a PR!
|
flotwig
force-pushed
the
semantic-pr-title-action
branch
from
0976453
to
859e5f7
Compare
flotwig
requested review from
jennifer-shehane
and removed request for
a team
| name: Lint Title | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v4 |
There was a problem hiding this comment.
@flotwig Is this a certified GitHub action? I know we've hesitated bringing in randomly published github actions since they get permissions to our repo which could be problematic.
There was a problem hiding this comment.
Doesn't seem to be. Should I fork it to cypress-io org to lock it down?
There was a problem hiding this comment.
Switched to using a fork under the cypress-io org.
There was a problem hiding this comment.
IMO we should use the existing repository instead of adding another forked repository to maintain. If issues occur, we can lean on the open-source community to contribute to the fixes.
There was a problem hiding this comment.
The issue is that at any point the action publisher can re-tag a release. You can mitigate this by using a SHA1 hash but there can still be a collision. GitHub recommends only using 3rd party actions by "authors you trust": https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
There was a problem hiding this comment.
My only ask is that we add a comment here explaining why we're pointing to a forked version of the repo. And maybe in the forked version of the repo's README as well, though that's less important.
There was a problem hiding this comment.
Discussed during our sync today. Moving forward with forked repository. 👍🏻
flotwig
force-pushed
the
semantic-pr-title-action
branch
from
859e5f7
to
d4c4534
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
* develop: feat: gray out the path to system node in cypress run header (#20121) feat: redesign server errors (#20072) test: fix awesome-typescript-loader test and remove test-binary job (#20131) fix: Fix issues with stack traces and command log in Chrome 99 (#20049) fix: `cy.type(' ')` fires click event on button-like elements. (#20067) fix: `change`, `input` events are not fired when the same option is selected again. (#19623) build: publish vue3 on latest (#20099) chore: release @cypress/webpack-preprocessor-v5.11.1 chore: release @cypress/webpack-dev-server-v1.8.1 fix: detect newly added specs in dev-server compilation (#17950) chore: Remove pkg/driver //@ts-nocheck part 3 (#19837) chore: set up semantic-pull-request GitHub Action (#20091) chore: release @cypress/react-v5.12.2 fix: remove nullish coalescing in js files to support node 12 (#20094) docs: update @cypress/webpack-preprocessor links (#19902) refactor: use aliases instead of meta (#19566)
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?Post-Merge: