Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix awesome-typescript-loader test and remove test-binary job #20131

Merged
merged 2 commits into from
Feb 10, 2022
Merged

test: fix awesome-typescript-loader test and remove test-binary job #20131

merged 2 commits into from
Feb 10, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 9, 2022 •
edited
Loading

User facing changelog

n/a

Additional details

  • Fixes awesome-typescript-loader system-test so we can kill the cypress-test-awesome-typescript-loader repo and CI job.
  • Note: awesome-typescript-loader is itself an archived repo - it does not support typescript 4, so that's why you see typescript 3 here. Still, we should keep the same amount of coverage against it, I don't want to look into replacing this coverage right now.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

Post-merge:

  • Remove awesome-typescript-loader example repo.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 9, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 9, 2022


Test summary

19185 • 0 • 218 • 0 • Flakiness 1

Run details
Project cypress
Status Passed
Commit 44841b2
Started Feb 9, 2022 11:35 PM
Ended Feb 9, 2022 11:46 PM
Duration 11:31 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/commands/net_stubbing_spec.ts 1 Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review February 9, 2022 23:57
@flotwig flotwig requested a review from sainthkh February 9, 2022 23:57
sainthkh
sainthkh approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@sainthkh sainthkh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to reference files in a weird way to avoid conflicts.

Your code is much better because referencing "cypress" loads them and tsconfig "type" option ignores node_modules types.

@flotwig flotwig merged commit be4c78b into develop Feb 10, 2022
@flotwig flotwig deleted the issue-18497-awesome-typescript-tests branch February 10, 2022 18:05
@cypress-bot cypress-bot bot mentioned this pull request Feb 10, 2022
Closed
tgriesser added a commit that referenced this pull request Feb 14, 2022
@tgriesser
Merge branch 'develop' into 10.0-release
678bede 
* develop:
  feat: gray out the path to system node in cypress run header (#20121)
  feat: redesign server errors (#20072)
  test: fix awesome-typescript-loader test and remove test-binary job (#20131)
  fix: Fix issues with stack traces and command log in Chrome 99 (#20049)
  fix: `cy.type(' ')` fires click event on button-like elements. (#20067)
  fix: `change`, `input` events are not fired when the same option is selected again. (#19623)
  build: publish vue3 on latest (#20099)
  chore: release @cypress/webpack-preprocessor-v5.11.1
  chore: release @cypress/webpack-dev-server-v1.8.1
  fix: detect newly added specs in dev-server compilation (#17950)
  chore: Remove pkg/driver //@ts-nocheck part 3 (#19837)
  chore: set up semantic-pull-request GitHub Action (#20091)
  chore: release @cypress/react-v5.12.2
  fix: remove nullish coalescing in js files to support node 12 (#20094)
  docs: update @cypress/webpack-preprocessor links (#19902)
  refactor: use aliases instead of meta (#19566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanthemanuel ryanthemanuel ryanthemanuel approved these changes

@sainthkh sainthkh sainthkh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error_ui system test
3 participants
@flotwig @ryanthemanuel @sainthkh