Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add possible frameworks to object API config #21056

Merged
merged 1 commit into from Apr 13, 2022

Conversation

tgriesser
Copy link
Member

Additional details

Fixes the types for the frameworks in the Cypress d.ts

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@tgriesser tgriesser requested review from a team as code owners April 13, 2022 00:22
@tgriesser tgriesser requested review from jennifer-shehane and removed request for a team April 13, 2022 00:22
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 13, 2022

Thanks for taking the time to open a PR!

@tgriesser tgriesser requested review from ZachJW34 and lmiller1990 and removed request for a team and jennifer-shehane April 13, 2022 00:22
@cypress
Copy link

cypress bot commented Apr 13, 2022



Test summary

17841 0 218 0Flakiness 0


Run details

Project cypress
Status Passed
Commit ea23a83
Started Apr 13, 2022 12:25 AM
Ended Apr 13, 2022 12:38 AM
Duration 12:52 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tgriesser tgriesser merged commit 001a724 into 10.0-release Apr 13, 2022
@tgriesser tgriesser deleted the tgriesser/fix/object-api-types branch April 13, 2022 12:41
tgriesser added a commit that referenced this pull request Apr 13, 2022
…o/cypress into tgriesser/fix/UNIFY-1206-cloud

* 'tgriesser/fix/UNIFY-1206-cloud' of github.com:cypress-io/cypress:
  feat: swap the #__cy_root id selector to become data-cy-root for component mounting (#20951)
  fix: Doc changes around vue2 (#21066)
  feat: Add vue2 package from npm/vue/v2 branch (#21026)
  fix: add possible frameworks to object API config (#21056)
tgriesser added a commit that referenced this pull request Apr 14, 2022
* 10.0-release: (25 commits)
  fix: stop running spec when switching specs (#21038)
  fix: remove asset size warnings and enable nuxt e2e tests (#21074)
  feat: swap the #__cy_root id selector to become data-cy-root for component mounting (#20951)
  fix: Doc changes around vue2 (#21066)
  feat: Add vue2 package from npm/vue/v2 branch (#21026)
  skip failing test
  fix: add possible frameworks to object API config (#21056)
  fix snapshot spacing
  fix system test
  fix snapshot
  update snapshots
  rename spec files
  rename files
  update snapshots
  release 9.5.4 [skip ci]
  fix(regression): cy.pause() should not be ignored with `cypress run --headed --no-exit` (#20877)
  fix: add missing Cypress.Commands.addAll() types (#20894)
  chore: Don't store video and screenshot artifacts for runs (#20979)
  chore: Update Chrome (beta) to 101.0.4951.26 (#20957)
  chore: remove parallelism from test-binary-against-repo jobs (#21004)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants