fix: stop running spec when switching specs #21038
Conversation
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
estrada9166
requested review from
jennifer-shehane
and removed request for
a team
…b.com:cypress-io/cypress into alejandro/fix/emit-stop-while-switching-specs
…b.com:cypress-io/cypress into alejandro/fix/emit-stop-while-switching-specs
There was a problem hiding this comment.
When will this log be shown? If you navigate away, eg to another test, won't that one start running (and clear the command log?)
Guessing this was never a problem in 9.x since you could not really navigate away from a spec? But what about if you changed the url? I'm kind of surprised you had to patch this in the driver - it feels like something that should have been introduced in 10.x, but patching the driver suggests this same bug should be reproducible in 9.x, too 🤔
This is going to be only shown when you are running a test and stop it while running, if you change the spec it's not going to log anything as it should be
This may be related to how we update the states when mounting and unmounting the components when you switch specs on v10 from the side nav, it do not unmount the component, so, there're significative changes related with how it was |
|
Let's ship it |
* 10.0-release: (25 commits) fix: stop running spec when switching specs (#21038) fix: remove asset size warnings and enable nuxt e2e tests (#21074) feat: swap the #__cy_root id selector to become data-cy-root for component mounting (#20951) fix: Doc changes around vue2 (#21066) feat: Add vue2 package from npm/vue/v2 branch (#21026) skip failing test fix: add possible frameworks to object API config (#21056) fix snapshot spacing fix system test fix snapshot update snapshots rename spec files rename files update snapshots release 9.5.4 [skip ci] fix(regression): cy.pause() should not be ignored with `cypress run --headed --no-exit` (#20877) fix: add missing Cypress.Commands.addAll() types (#20894) chore: Don't store video and screenshot artifacts for runs (#20979) chore: Update Chrome (beta) to 101.0.4951.26 (#20957) chore: remove parallelism from test-binary-against-repo jobs (#21004) ...
User facing changelog
Additional details
When there was a spec running and the user changed the spec, the running spec timed out, affecting the state of the new spec, showing the timed out result in the new fresh spec which does not have any failure
Update error message when the test was stopped while running
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?